Conversation
trygu
requested review from
JohannesFinsveen,
MikaelNordberg,
likp,
oyessb and
runejo
as code owners
|
There is still an issue related to Px-files without CODE for Time.. since .TimeValue is missing (or wrong), which makes the datetime creation fail. |
| // the data which follows VALUES(...). | ||
| row[dataFieldIndices[variable.Name]] = value; // Original time-value (from VALUES) | ||
| row[dataFieldIndices["timestamp"]] = ParseTimeScale(value, variable.TimeScale); // Parsed timestamp | ||
| value = variable.Values[index[i]].TimeValue; |
There was a problem hiding this comment.
@trygu why did you add this line again?
value = variable.Values[index[i]].TimeValue;
If I remove it the 14216.parquet works
{"tettsted":"0801","år":"2025","timestamp":1735689600000,"ContentsCode_Areal":275.87,"ContentsCode_Areal_symbol":null,"ContentsCode_Bosatte":1110887,"ContentsCode_Bosatte_symbol":null}
{"tettsted":"0801","år":"2024","timestamp":1704067200000,"ContentsCode_Areal":276.3,"ContentsCode_Areal_symbol":null,"ContentsCode_Bosatte":1098061,"ContentsCode_Bosatte_symbol":null}
There was a problem hiding this comment.
I get it, I didn't know that TimeValue looked like 20071 and the Code is 2007K1
There was a problem hiding this comment.
I can make it work in the ParquetSerilizer using Code and Value, but the real problem seems to be in Paxiom. TimeValue is clearly wrong. Can we discuss it tomorrow @likp ?
There was a problem hiding this comment.
Ok, we discussed it yesterday in our weekly PxWebApi meeting, and we agreed to make it work without looking at TimeValue. I'll commit the fix on this branch now.
|
3 participants
Fixes PxTools/PxWebApi#511